[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20201226080258.6576-1-dinghao.liu@zju.edu.cn>
Date: Sat, 26 Dec 2020 16:02:56 +0800
From: Dinghao Liu <dinghao.liu@....edu.cn>
To: dinghao.liu@....edu.cn, kjlu@....edu
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Camylla Goncalves Cantanheide <c.cantanheide@...il.com>,
Zhang Qilong <zhangqilong3@...wei.com>,
Colin Ian King <colin.king@...onical.com>,
Masahiro Yamada <masahiroy@...nel.org>,
Michael Straube <straube.linux@...il.com>,
Allen Pais <apais@...ux.microsoft.com>,
devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: [PATCH] staging: rtl8192u: Add null check in rtl8192_usb_initendpoints
There is an allocation for priv->rx_urb[16] has no null check,
which may lead to a null pointer dereference.
Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>
---
drivers/staging/rtl8192u/r8192U_core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
index 93676af98629..9fc4adc83d77 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -1608,6 +1608,8 @@ static short rtl8192_usb_initendpoints(struct net_device *dev)
void *oldaddr, *newaddr;
priv->rx_urb[16] = usb_alloc_urb(0, GFP_KERNEL);
+ if (!priv->rx_urb[16])
+ return -ENOMEM;
priv->oldaddr = kmalloc(16, GFP_KERNEL);
if (!priv->oldaddr)
return -ENOMEM;
--
2.17.1
Powered by blists - more mailing lists