linux-kernel - Re: [PATCH] sched: pull tasks when CPU is about to run SCHED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202012280334.i7CbyJdy-lkp@intel.com>
Date:   Mon, 28 Dec 2020 03:13:59 +0800
From:   kernel test robot <lkp@...el.com>
To:     ultrachin@....com, linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, mingo@...hat.com, peterz@...radead.org,
        juri.lelli@...hat.com, vincent.guittot@...aro.org,
        dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
        mgorman@...e.de, bristot@...hat.com
Subject: Re: [PATCH] sched: pull tasks when CPU is about to run SCHED_IDLE
 tasks

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/sched/core]
[also build test ERROR on tip/master linux/master linus/master v5.10 next-20201223]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/ultrachin-163-com/sched-pull-tasks-when-CPU-is-about-to-run-SCHED_IDLE-tasks/20201223-175522
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 5b78f2dc315354c05300795064f587366a02c6ff
config: microblaze-randconfig-r023-20201223 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/3dc62b606dd00e8c8935ff6b85d8bf26a960842b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review ultrachin-163-com/sched-pull-tasks-when-CPU-is-about-to-run-SCHED_IDLE-tasks/20201223-175522
        git checkout 3dc62b606dd00e8c8935ff6b85d8bf26a960842b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   kernel/sched/fair.c: In function 'pick_next_task_fair':
   kernel/sched/fair.c:7034:6: error: implicit declaration of function 'sched_idle_cpu'; did you mean 'sched_idle_rq'? [-Werror=implicit-function-declaration]
    7034 |      sched_idle_cpu(rq->cpu))
         |      ^~~~~~~~~~~~~~
         |      sched_idle_rq
>> kernel/sched/fair.c:7034:23: error: 'struct rq' has no member named 'cpu'
    7034 |      sched_idle_cpu(rq->cpu))
         |                       ^~
   cc1: some warnings being treated as errors


vim +7034 kernel/sched/fair.c

  7023	
  7024	struct task_struct *
  7025	pick_next_task_fair(struct rq *rq, struct task_struct *prev, struct rq_flags *rf)
  7026	{
  7027		struct cfs_rq *cfs_rq = &rq->cfs;
  7028		struct sched_entity *se;
  7029		struct task_struct *p;
  7030		int new_tasks;
  7031	
  7032		if (prev &&
  7033		    fair_policy(prev->policy) &&
> 7034		    sched_idle_cpu(rq->cpu))
  7035			goto idle;
  7036	
  7037	again:
  7038		if (!sched_fair_runnable(rq))
  7039			goto idle;
  7040	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (34704 bytes)