linux-kernel - Re: LXC broken with 5.10-stable?, ok with 5.9-stable (Re: Linux 5.10.3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=whF=+EzrxP=3zNMH-1L2Nfs7fNoSufqDwOdRQo5qyMwfw@mail.gmail.com>
Date:   Sun, 27 Dec 2020 12:12:00 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Jussi Kivilinna <jussi.kivilinna@....fi>,
        Christoph Hellwig <hch@....de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        stable <stable@...r.kernel.org>, lwn@....net,
        Jiri Slaby <jslaby@...e.cz>
Subject: Re: LXC broken with 5.10-stable?, ok with 5.9-stable (Re: Linux 5.10.3)

On Sun, Dec 27, 2020 at 11:05 AM Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> On Sun, Dec 27, 2020 at 10:39 AM Jussi Kivilinna <jussi.kivilinna@....fi> wrote:
> >
> > 5.10.3 with patch compiles fine, but does not solve the issue.
>
> Duh. adding the read_iter only fixes kernel_read(). For splice, it also needs a
>
>         .splice_read = generic_file_splice_read,
>
> in the file operations, something like this...

Ok, I verified that patch with the test-case in the bugzilla, and it
seems trivially fine.

So it's committed as 14e3e989f6a5 ("proc mountinfo: make splice
available again") now.

             Linus