linux-kernel - Re: [RFC PATCH 3/3] gpio: ep93xx: specify gpio_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdaB2OXrVo+8cEMY_vLODnQXsuv72bu12qBusxFj++H9HA@mail.gmail.com>
Date:   Sun, 27 Dec 2020 22:22:43 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Nikita Shubin <nikita.shubin@...uefel.me>
Cc:     Bartosz Golaszewski <bgolaszewski@...libre.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 3/3] gpio: ep93xx: specify gpio_irq_chip->first

On Thu, Dec 24, 2020 at 12:22 PM Nikita Shubin
<nikita.shubin@...uefel.me> wrote:

> Port F irq's should be statically mapped to EP93XX_GPIO_F_IRQ_BASE.
>
> So we need to specify girq->first otherwise:
>
> "If device tree is used, then first_irq will be 0 and
> irqs get mapped dynamically on the fly"
>
> And that's not the thing we want.
>
> Signed-off-by: Nikita Shubin <nikita.shubin@...uefel.me>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

We can only fix this properly once we convert the platform
to device tree. (Along with making the irqchip hierarchical.)

Yours,
Linus Walleij