linux-kernel - Re: LXC broken with 5.10-stable?, ok with 5.9-stable (Re: Linux 5.10.3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHk-=wiXQVE_jGN0ajk+Km925WSbCL16mAZ-UXNkp+nkc1nuQw@mail.gmail.com>
Date:   Sun, 27 Dec 2020 15:14:49 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     Jussi Kivilinna <jussi.kivilinna@....fi>,
        Christoph Hellwig <hch@....de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        stable <stable@...r.kernel.org>, lwn@....net,
        Jiri Slaby <jslaby@...e.cz>
Subject: Re: LXC broken with 5.10-stable?, ok with 5.9-stable (Re: Linux 5.10.3)

On Sun, Dec 27, 2020 at 1:25 PM Al Viro <viro@...iv.linux.org.uk> wrote:
>
>
> Is there any point in not doing the same (scripted, obviously) for
> all instances with .read == seq_read?  IIRC, Christoph even posted
> something along those lines, but it went nowhere for some reason...

I'd rather limit splice (and kernel_read too, for that matter) as much
as possible. It was a mistake originally to allow it everywhere, and
it's come back to bite us.

So I'd rather have people notice these odd corner cases and get them
fixed one by one than just say "anything goes".

There's hopefully not any actually left anyway...

                  Linus