linux-kernel - Re: [PATCH 2/2] m68k: let clk_enable() return immediately if clk is NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87bleffdyv.fsf@igel.home>
Date:   Sun, 27 Dec 2020 16:47:20 +0100
From:   Andreas Schwab <schwab@...ux-m68k.org>
To:     Defang Bo <bodefang@....com>
Cc:     gerg@...ux-m68k.org, geert@...ux-m68k.org,
        linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] m68k: let clk_enable() return immediately if clk is
 NULL

On Dez 27 2020, Defang Bo wrote:

> diff --git a/arch/m68k/coldfire/clk.c b/arch/m68k/coldfire/clk.c
> index 7bc666e..cf1ed97 100644
> --- a/arch/m68k/coldfire/clk.c
> +++ b/arch/m68k/coldfire/clk.c
> @@ -90,6 +90,9 @@ EXPORT_SYMBOL(clk_get);
>  int clk_enable(struct clk *clk)
>  {
>  	unsigned long flags;
> +	if (!clk)
> +		return;

That fails to return a value.

Andreas.

-- 
Andreas Schwab, schwab@...ux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."