linux-kernel - [PATCH] kgdbts: Passing ekgdbts to command line causes panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1609120450-199726-1-git-send-email-bodefang@126.com>
Date:   Mon, 28 Dec 2020 09:54:10 +0800
From:   Defang Bo <bodefang@....com>
To:     jason.wessel@...driver.com, daniel.thompson@...aro.org,
        dianders@...omium.org, arnd@...db.de, gregkh@...uxfoundation.org,
        kgdb-bugreport@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Cc:     Defang Bo <bodefang@....com>
Subject: [PATCH] kgdbts: Passing ekgdbts to command line causes panic

Similar to commit<1bd54d851f50>(("kgdboc: Passing ekgdboc to command line causes panic"),
kgdbts_option_setup does not check input argument before passing it to strlen.
The argument would be a NULL pointer.

Signed-off-by: Defang Bo <bodefang@....com>
---
 drivers/misc/kgdbts.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/misc/kgdbts.c b/drivers/misc/kgdbts.c
index 945701b..b077547 100644
--- a/drivers/misc/kgdbts.c
+++ b/drivers/misc/kgdbts.c
@@ -1057,6 +1057,11 @@ static void kgdbts_run_tests(void)
 
 static int kgdbts_option_setup(char *opt)
 {
+	if (!opt) {
+		pr_err("kgdbts: config string not provided\n");
+		return -EINVAL;
+	}
+
 	if (strlen(opt) >= MAX_CONFIG_LEN) {
 		printk(KERN_ERR "kgdbts: config string too long\n");
 		return -ENOSPC;
-- 
2.7.4