linux-kernel - [PATCH] media: v4l2-async: Put fwnode after last access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20201228121725.133898-1-ezequiel@collabora.com>
Date:   Mon, 28 Dec 2020 09:17:25 -0300
From:   Ezequiel Garcia <ezequiel@...labora.com>
To:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     kernel@...labora.com, Hans Verkuil <hverkuil@...all.nl>,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
        Ezequiel Garcia <ezequiel@...labora.com>
Subject: [PATCH] media: v4l2-async: Put fwnode after last access

fwnode_handle_put() should be called after the fwnode
is last accessed. Fix it.

Fixes: b98158d837ef ("media: v4l2-async: Accept endpoints and devices for fwnode matching")
Signed-off-by: Ezequiel Garcia <ezequiel@...labora.com>
---
 drivers/media/v4l2-core/v4l2-async.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c
index e3ab003a6c85..1303c9b83138 100644
--- a/drivers/media/v4l2-core/v4l2-async.c
+++ b/drivers/media/v4l2-core/v4l2-async.c
@@ -78,6 +78,7 @@ static bool match_fwnode(struct v4l2_async_notifier *notifier,
 	bool asd_fwnode_is_ep;
 	bool sd_fwnode_is_ep;
 	struct device *dev;
+	bool match;
 
 	/*
 	 * Both the subdev and the async subdev can provide either an endpoint
@@ -113,9 +114,10 @@ static bool match_fwnode(struct v4l2_async_notifier *notifier,
 		other_fwnode = sd->fwnode;
 	}
 
-	fwnode_handle_put(dev_fwnode);
+	match = (dev_fwnode == other_fwnode);
 
-	if (dev_fwnode != other_fwnode)
+	fwnode_handle_put(dev_fwnode);
+	if (!match)
 		return false;
 
 	/*
-- 
2.29.2