linux-kernel - Re: [PATCH -next] regulator: qcom-rpmh: fix build after QCOM_COMMAND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X+k/RZ1LnG2Wx7FH@codeaurora.org>
Date:   Sun, 27 Dec 2020 19:13:25 -0700
From:   Lina Iyer <ilina@...eaurora.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, rnayak@...eaurora.org
Subject: Re: [PATCH -next] regulator: qcom-rpmh: fix build after
 QCOM_COMMAND_DB is tristate

On Fri, Dec 25 2020 at 11:50 -0700, Randy Dunlap wrote:
>Restrict REGULATOR_QCOM_RPMH to QCOM_COMMAND_DB it the latter is enabled.
>
>Fixes this build error:
>  microblaze-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_probe':
>  (.text+0x354): undefined reference to `cmd_db_read_addr'
>
>Fixes: 778279f4f5e4 ("soc: qcom: cmd-db: allow loading as a module")
>Reported-by: kernel test robot <lkp@...el.com>
>Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>Cc: Lina Iyer <ilina@...eaurora.org>
>Cc: Liam Girdwood <lgirdwood@...il.com>
>Cc: Mark Brown <broonie@...nel.org>
Reviewed-by: Lina Iyer <ilina@...eaurora.org>

>---
> drivers/regulator/Kconfig |    1 +
> 1 file changed, 1 insertion(+)
>
>--- linux-next-20201223.orig/drivers/regulator/Kconfig
>+++ linux-next-20201223/drivers/regulator/Kconfig
>@@ -881,6 +881,7 @@ config REGULATOR_QCOM_RPM
> config REGULATOR_QCOM_RPMH
> 	tristate "Qualcomm Technologies, Inc. RPMh regulator driver"
> 	depends on QCOM_RPMH || (QCOM_RPMH=n && COMPILE_TEST)
>+	depends on QCOM_COMMAND_DB || !QCOM_COMMAND_DB
> 	help
> 	  This driver supports control of PMIC regulators via the RPMh hardware
> 	  block found on Qualcomm Technologies Inc. SoCs.  RPMh regulator