linux-kernel - Re: Linux 5.11-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wh3AsdUVZ8GKNCdUmY0_nGmoiOVTwy7rR5QM7K31QiSqw@mail.gmail.com>
Date:   Mon, 28 Dec 2020 11:40:22 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Sedat Dilek <sedat.dilek@...il.com>
Cc:     Masahiro Yamada <masahiroy@...nel.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Linux 5.11-rc1

On Mon, Dec 28, 2020 at 12:04 AM Sedat Dilek <sedat.dilek@...il.com> wrote:
>
> > $ dpkg -L kmod | grep bin | grep depmod
> > /sbin/depmod
> >
> > $ which depmod
> > [ empty ]
> >
> > $ echo $PATH
> > /opt/proxychains-ng/bin:/home/dileks/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games

Ok, I think this is a broken setup that has a separate /sbin but does
not have it in the PATH.

As you noticed, you can fix it with

   DEPMOD=/sbin/depmod

or you could just make /sbin part of your PATH.

It looks like on your distro, /sbin is restricted to just the
super-user PATH, which is odd, but I guess there's at least _some_
logic to it.

I guess we could have some compatibility thing in scripts/depmod.sh,
something like

  diff --git a/scripts/depmod.sh b/scripts/depmod.sh
  index e083bcae343f..a93261207453 100755
  --- a/scripts/depmod.sh
  +++ b/scripts/depmod.sh
  @@ -15,6 +15,8 @@ if ! test -r System.map ; then
        exit 0
   fi

  +# legacy behavior: "depmod" in /sbin
  +PATH="$PATH:/sbin"
   if [ -z $(command -v $DEPMOD) ]; then
        echo "Warning: 'make modules_install' requires $DEPMOD. Please
install it." >&2
        echo "This is probably in the kmod package." >&2

or similar. Does that work for you?

                Linus