linux-kernel - Re: Re: [PATCH] IB/sa: Fix memleak in ib_nl_make

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <17c0fdb1.7819.176a750f929.Coremail.dinghao.liu@zju.edu.cn>
Date:   Mon, 28 Dec 2020 11:07:50 +0800 (GMT+08:00)
From:   dinghao.liu@....edu.cn
To:     "Leon Romanovsky" <leon@...nel.org>
Cc:     kjlu@....edu, "Doug Ledford" <dledford@...hat.com>,
        "Jason Gunthorpe" <jgg@...pe.ca>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        "Ursula Braun" <ubraun@...ux.ibm.com>,
        Håkon Bugge <haakon.bugge@...cle.com>,
        "Divya Indi" <divya.indi@...cle.com>,
        "Mauro Carvalho Chehab" <mchehab+huawei@...nel.org>,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH] IB/sa: Fix memleak in ib_nl_make_request

> On Sun, Dec 20, 2020 at 04:13:14PM +0800, Dinghao Liu wrote:
> > When rdma_nl_multicast() fails, skb should be freed
> > just like when ibnl_put_msg() fails.
> 
> It is not so simple as you wrote in the description.
> 
> There are no other places in the linux kernel that free
> SKBs after netlink_multicast() failure.
> 

It's clear for me, thanks.

Regards,
Dinghao