linux-kernel - Re: [PATCH 1/3] dt-bindings: input: cros-ec-keyb: Add a new property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X+rKPhJrQaykPxri@google.com>
Date:   Mon, 28 Dec 2020 22:18:38 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Philip Chen <philipchen@...omium.org>
Cc:     LKML <linux-kernel@...r.kernel.org>, dtor@...omium.org,
        swboyd@...omium.org, dianders@...omium.org, rajatja@...omium.org,
        Benson Leung <bleung@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>,
        Rob Herring <robh+dt@...nel.org>,
        Simon Glass <sjg@...omium.org>, devicetree@...r.kernel.org,
        linux-input@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: input: cros-ec-keyb: Add a new property

Hi Philip,

On Mon, Dec 21, 2020 at 05:47:57PM -0800, Philip Chen wrote:
> This patch adds a new property `google,custom-keyb-top-row` to the
> device tree for the custom keyboard top row design.

Why don't we use the property we have for the same purpose in atkbd.c?
I.e. function-row-physmap?

Also, instead of specifying keycodes in this array we should use
combination of row and column identifying keys, like this:

	function-row-physmap = <
		MATRIX_KEY(0x00, 0x02, KEY_F1),
		MATRIX_KEY(0x03, 0x02, KEY_F2),
		...
	>;

Note that the last item in the triple is purely cosmetic in this case,
you can change it to 0. It is row and column that are important.

Then the mapping will work properly even if we change keymap, for
example from userspace.

Thanks.

-- 
Dmitry