linux-kernel - Re: [PATCH] input: ariel-pwrbutton.c: Remove unused variable ariel_pwrbutton_id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Dec 2020 13:15:10 +0530
From:   Souptick Joarder <jrdr.linux@...il.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Lubomir Rintel <lkundrak@...sk>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] input: ariel-pwrbutton.c: Remove unused variable ariel_pwrbutton_id_table[]

On Tue, Dec 22, 2020 at 1:34 AM Souptick Joarder <jrdr.linux@...il.com> wrote:
>
> Kernel test robot throws below warning ->
>
> >> drivers/input/misc/ariel-pwrbutton.c:152:35: warning: unused variable
> >> 'ariel_pwrbutton_id_table' [-Wunused-const-variable]
>    static const struct spi_device_id ariel_pwrbutton_id_table[] = {
>                                      ^
>    1 warning generated.
>
> Remove unused variable ariel_pwrbutton_id_table[] if no plan to use
> it further.
>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>

Any comment on this patch ?

> ---
>  drivers/input/misc/ariel-pwrbutton.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/input/misc/ariel-pwrbutton.c b/drivers/input/misc/ariel-pwrbutton.c
> index eda86ab..17bbaac 100644
> --- a/drivers/input/misc/ariel-pwrbutton.c
> +++ b/drivers/input/misc/ariel-pwrbutton.c
> @@ -149,12 +149,6 @@ static int ariel_pwrbutton_probe(struct spi_device *spi)
>  };
>  MODULE_DEVICE_TABLE(of, ariel_pwrbutton_of_match);
>
> -static const struct spi_device_id ariel_pwrbutton_id_table[] = {
> -       { "wyse-ariel-ec-input", 0 },
> -       {}
> -};
> -MODULE_DEVICE_TABLE(spi, ariel_pwrbutton_id_table);
> -
>  static struct spi_driver ariel_pwrbutton_driver = {
>         .driver = {
>                 .name = "dell-wyse-ariel-ec-input",
> --
> 1.9.1
>