linux-kernel - Re: [GIT PULL] xfs: new code for 5.11

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201229104955.565423f9@note>
Date:   Tue, 29 Dec 2020 10:49:55 +0300
From:   Dmitrii Tcvetkov <me@...sh.org>
To:     djwong@...nel.org
Cc:     david@...morbit.com, hch@....de, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-xfs@...r.kernel.org,
        sandeen@...deen.net, torvalds@...ux-foundation.org
Subject: Re: [GIT PULL] xfs: new code for 5.11

>Please pull the following branch containing all the new xfs code for
>5.11.  In this release we add the ability to set a 'needsrepair' flag
>indicating that we /know/ the filesystem requires xfs_repair, but other
>than that, it's the usual strengthening of metadata validation and
>miscellaneous cleanups.
>...
>New code for 5.11:
>- Introduce a "needsrepair" "feature" to flag a filesystem as needing a
>  pass through xfs_repair.  This is key to enabling filesystem upgrades
>  (in xfs_db) that require xfs_repair to make minor adjustments to
>metadata.

Hello.

Most likely I miss something obvious but according to xfs_repair(8):
BUGS:
The filesystem to be checked and repaired must have been unmounted
cleanly  using  normal  system  administration  procedures (the
umount(8)  command  or  system  shutdown),  not  as  a  result of a
crash or system reset.  If the filesystem has not been unmounted
cleanly, mount it and unmount it cleanly before running xfs_repair.

which is there since commit d321ceac "add libxlog directory"
Date:   Wed Oct 17 11:00:32 2001 +0000 in xfsprogs-dev[1]. 

So will be there situation of uncleanly unmounted filesystem with
"needsrepair" bit set? Will one be able to mount and umount it before
running xfs_repair in that case?

[1] git://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git