lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 29 Dec 2020 11:40:54 +0000 From: Charles Keepax <ckeepax@...nsource.cirrus.com> To: Hans de Goede <hdegoede@...hat.com> CC: Lee Jones <lee.jones@...aro.org>, MyungJoo Ham <myungjoo.ham@...sung.com>, Chanwoo Choi <cw00.choi@...sung.com>, Cezary Rojewski <cezary.rojewski@...el.com>, Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>, Liam Girdwood <liam.r.girdwood@...ux.intel.com>, Jie Yang <yang.jie@...ux.intel.com>, Mark Brown <broonie@...nel.org>, <patches@...nsource.cirrus.com>, <linux-kernel@...r.kernel.org>, <alsa-devel@...a-project.org> Subject: Re: [PATCH 02/14] mfd: arizona: Add MODULE_SOFTDEP("pre: arizona_ldo1") On Sun, Dec 27, 2020 at 10:12:20PM +0100, Hans de Goede wrote: > The (shared) probing code of the arizona-i2c and arizona-spi modules > takes the following steps during init: > > 1. Call mfd_add_devices() for a set of early child-devices, this > includes the arizona_ldo1 device which provides one of the > core-regulators. > > 2. Bulk enable the core-regulators. > > 3. Read the device id. > > 4. Call mfd_add_devices() for the other child-devices. > > This sequence depends on 1. leading to not only the child-device > being created, but also the driver for the child-device binding > to it and registering its regulator. > > This requires the arizona_ldo1 driver to be loaded before the > shared probing code runs. Add a doftdep for this to both modules to > ensure that this requirement is met. > > Note this mirrors the existing MODULE_SOFTDEP("pre: wm8994_regulator") > in the wm8994 code, which has a similar init sequence. > > Signed-off-by: Hans de Goede <hdegoede@...hat.com> > --- Acked-by: Charles Keepax <ckeepax@...nsource.cirrus.com> Thanks, Charles
Powered by blists - more mailing lists