lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 29 Dec 2020 21:40:06 +0800 From: Zenghui Yu <yuzenghui@...wei.com> To: <linux-kernel@...r.kernel.org>, <iommu@...ts.linux-foundation.org>, <hch@....de>, <m.szyprowski@...sung.com>, <robin.murphy@....com> CC: <wanghaibin.wang@...wei.com>, Zenghui Yu <yuzenghui@...wei.com> Subject: [PATCH] dma-debug: Delete outdated comment of the hash function We actually use dev_addr[26:13] as the index into dma_entry_hash. Given that the code itself is clear enough, let's drop the hardcoded comment so that we won't need to revisit it every time HASH_FN_{SHIFT,MASK} gets updated. Signed-off-by: Zenghui Yu <yuzenghui@...wei.com> --- kernel/dma/debug.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/kernel/dma/debug.c b/kernel/dma/debug.c index 14de1271463f..d89341162d35 100644 --- a/kernel/dma/debug.c +++ b/kernel/dma/debug.c @@ -235,10 +235,7 @@ static bool driver_filter(struct device *dev) */ static int hash_fn(struct dma_debug_entry *entry) { - /* - * Hash function is based on the dma address. - * We use bits 20-27 here as the index into the hash - */ + /* Hash function is based on the dma address. */ return (entry->dev_addr >> HASH_FN_SHIFT) & HASH_FN_MASK; } -- 2.19.1
Powered by blists - more mailing lists