lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 29 Dec 2020 07:54:47 -0600 From: Alex Elder <elder@...e.org> To: Zheng Yongjun <zhengyongjun3@...wei.com>, rmfrfs@...il.com, johan@...nel.org, elder@...nel.org, gregkh@...uxfoundation.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH -next] staging: greybus: light: Use kzalloc for allocating only one thing On 12/29/20 7:50 AM, Zheng Yongjun wrote: > Use kzalloc rather than kcalloc(1,...) > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > @@ > > - kcalloc(1, > + kzalloc( > ...) > // </smpl> > > Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com> > --- > drivers/staging/greybus/light.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c > index d2672b65c3f4..d227382fca20 100644 > --- a/drivers/staging/greybus/light.c > +++ b/drivers/staging/greybus/light.c > @@ -290,7 +290,7 @@ static int channel_attr_groups_set(struct gb_channel *channel, > channel->attrs = kcalloc(size + 1, sizeof(*channel->attrs), GFP_KERNEL); > if (!channel->attrs) > return -ENOMEM; > - channel->attr_group = kcalloc(1, sizeof(*channel->attr_group), > + channel->attr_group = kzalloc(sizeof(*channel->attr_group), > GFP_KERNEL); Looks good but that shortens the line enough to avoid a line wrap. Please send v2 with GFP_KERNEL on the same line as the kzalloc() call. -Alex > if (!channel->attr_group) > return -ENOMEM; >
Powered by blists - more mailing lists