linux-kernel - Re: [PATCH 2/2] ARM: dts: exynos: use Exynos5420 dedicated USB2 PHY compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Dec 2020 16:31:58 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Marek Szyprowski <m.szyprowski@...sung.com>
Cc:     linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Vinod Koul <vkoul@...nel.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Willy Wolff <willy.mh.wolff.ml@...il.com>,
        Marian Mihailescu <mihailescu2m@...il.com>
Subject: Re: [PATCH 2/2] ARM: dts: exynos: use Exynos5420 dedicated USB2 PHY
 compatible

On Fri, Nov 20, 2020 at 12:07:44PM +0100, Marek Szyprowski wrote:
> Hi Krzysztof,
> 
> On 20.11.2020 12:05, Krzysztof Kozlowski wrote:
> > On Fri, Nov 20, 2020 at 09:56:37AM +0100, Marek Szyprowski wrote:
> >> USB2.0 PHY in Exynos5420 differs from Exynos5250 variant a bit, so use the
> >> recently introduced dedicated compatible for Exynos5420.
> >>
> >> Signed-off-by: Marek Szyprowski <m.szyprowski@...sung.com>
> >> ---
> >>   arch/arm/boot/dts/exynos54xx.dtsi | 6 +++---
> >>   1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos54xx.dtsi b/arch/arm/boot/dts/exynos54xx.dtsi
> >> index fe9d34c23374..2ddb7a5f12b3 100644
> >> --- a/arch/arm/boot/dts/exynos54xx.dtsi
> >> +++ b/arch/arm/boot/dts/exynos54xx.dtsi
> >> @@ -188,7 +188,7 @@
> >>   			compatible = "samsung,exynos4210-ehci";
> >>   			reg = <0x12110000 0x100>;
> >>   			interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
> >> -			phys = <&usb2_phy 1>;
> >> +			phys = <&usb2_phy 0>;
> >>   			phy-names = "host";
> >>   		};
> >>   
> >> @@ -196,12 +196,12 @@
> >>   			compatible = "samsung,exynos4210-ohci";
> >>   			reg = <0x12120000 0x100>;
> >>   			interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
> >> -			phys = <&usb2_phy 1>;
> >> +			phys = <&usb2_phy 0>;
> >>   			phy-names = "host";
> >>   		};
> >>   
> >>   		usb2_phy: phy@...30000 {
> >> -			compatible = "samsung,exynos5250-usb2-phy";
> >> +			compatible = "samsung,exynos5420-usb2-phy";
> > The DTS change will wait till PHY driver adjustements get merged... or
> > if the difference is not critical, maybe using both compatibles (5420
> > and 5250) would have sense?
> 
> It won't work easily with both compatibles, because in the 5420 variant 
> I've also changed the PHY indices (5420 has no device and second hsic 
> phy). IMHO the dts change can wait for the next release.

Thanks, applied.

Best regards,
Krzysztof