lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 29 Dec 2020 16:43:11 +0100 From: Krzysztof Kozlowski <krzk@...nel.org> To: Chanwoo Choi <cw00.choi@...sung.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>, Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh+dt@...nel.org>, Lee Jones <lee.jones@...aro.org>, Sebastian Reichel <sre@...nel.org>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Andy Gross <agross@...nel.org>, Bjorn Andersson <bjorn.andersson@...aro.org>, Alessandro Zummo <a.zummo@...ertech.it>, Alexandre Belloni <alexandre.belloni@...tlin.com>, linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org, devicetree@...r.kernel.org, linux-pm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, linux-arm-msm@...r.kernel.org, linux-rtc@...r.kernel.org Cc: Iskren Chernev <iskren.chernev@...il.com>, Matheus Castello <matheus@...tello.eng.br>, Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>, Angus Ainslie <angus@...ea.ca>, Hans de Goede <hdegoede@...hat.com> Subject: Re: [PATCH 03/18] ARM: dts: exynos: correct fuel gauge interrupt trigger level on Midas family On Thu, Dec 10, 2020 at 10:25:19PM +0100, Krzysztof Kozlowski wrote: > The Maxim fuel gauge datasheets describe the interrupt line as active > low with a requirement of acknowledge from the CPU. The falling edge > interrupt will mostly work but it's not correct. > > Fixes: e8614292cd41 ("ARM: dts: Add Maxim 77693 fuel gauge node for exynos4412-trats2") > Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org> > --- > arch/arm/boot/dts/exynos4412-midas.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Hi Marek, I remember you were reporting that on Trats2 you see fuel gauge interrupt storm with this patchset. Is it correct? Shall I wait with applying this? Best regards, Krzysztof > diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi b/arch/arm/boot/dts/exynos4412-midas.dtsi > index 111c32bae02c..b8b75dc81aa1 100644 > --- a/arch/arm/boot/dts/exynos4412-midas.dtsi > +++ b/arch/arm/boot/dts/exynos4412-midas.dtsi > @@ -221,7 +221,7 @@ i2c_max77693_fuel: i2c-gpio-3 { > fuel-gauge@36 { > compatible = "maxim,max17047"; > interrupt-parent = <&gpx2>; > - interrupts = <3 IRQ_TYPE_EDGE_FALLING>; > + interrupts = <3 IRQ_TYPE_LEVEL_LOW>; > pinctrl-names = "default"; > pinctrl-0 = <&max77693_fuel_irq>; > reg = <0x36>; > -- > 2.25.1 >
Powered by blists - more mailing lists