linux-kernel - [PATCH] drm/amd/display: Initialize stack variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 29 Dec 2020 11:57:40 -0500
From:   Rodrigo Siqueira <Rodrigo.Siqueira@....com>
To:     LKML <linux-kernel@...r.kernel.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        amd-gfx@...ts.freedesktop.org
Cc:     Wesley Chalmers <Wesley.Chalmers@....com>,
        Alex Deucher <Alexander.Deucher@....com>,
        Alex Deucher <alexdeucher@...il.com>,
        Harry Wentland <Harry.Wentland@....com>,
        Nicholas Kazlauskas <Nicholas.Kazlauskas@....com>,
        Hersen Wu <hersenxs.wu@....com>,
        Dave Airlie <airlied@...il.com>,
        Josip Pavic <Josip.Pavic@....com>,
        Bindu Ramamurthy <bindu.r@....com>,
        Martin Leung <Martin.Leung@....com>
Subject: [PATCH] drm/amd/display: Initialize stack variable

From: Wesley Chalmers <Wesley.Chalmers@....com>

The stack variable "val" is potentially unpopulate it, so initialize it
with the value 0xf (indicating an invalid mux).

Cc: Alex Deucher <Alexander.Deucher@....com>
Cc: Alex Deucher <alexdeucher@...il.com>
Cc: Harry Wentland <Harry.Wentland@....com>
Cc: Nicholas Kazlauskas <Nicholas.Kazlauskas@....com>
Cc: Hersen Wu <hersenxs.wu@....com>
Cc: Dave Airlie <airlied@...il.com>
Cc: Josip Pavic <Josip.Pavic@....com>
Cc: Bindu Ramamurthy <bindu.r@....com>
Signed-off-by: Wesley Chalmers <Wesley.Chalmers@....com>
Reviewed-by: Martin Leung <Martin.Leung@....com>
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@....com>
---
 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mpc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mpc.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mpc.c
index a46cb20596fe..b096011acb49 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mpc.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mpc.c
@@ -470,7 +470,7 @@ void mpc1_cursor_lock(struct mpc *mpc, int opp_id, bool lock)
 unsigned int mpc1_get_mpc_out_mux(struct mpc *mpc, int opp_id)
 {
 	struct dcn10_mpc *mpc10 = TO_DCN10_MPC(mpc);
-	uint32_t val;
+	uint32_t val = 0xf;
 
 	if (opp_id < MAX_OPP && REG(MUX[opp_id]))
 		REG_GET(MUX[opp_id], MPC_OUT_MUX, &val);
-- 
2.30.0.rc2