lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 29 Dec 2020 22:22:05 +0100
From:   Thomas Petazzoni <>
To:     Nadeem Athani <>
Cc:     <>, <>,
        <>, <>, <>,
        <>, <>,
Subject: Re: [PATCH v6 1/2] PCI: cadence: Retrain Link to work around Gen2
 training defect.


The commit title is incorrect, it doesn't match what the patch is doing.

On Mon, 28 Dec 2020 15:05:09 +0100
Nadeem Athani <> wrote:

> Moving the function above to remove compilation error.
> No changes in function.

Which compilation error? I guess there is no compilation error, except
after your apply your PATCH 2/2. Is this correct ?

If so, this should be explained in this commit log: "Move the function
cdns_pcie_host_wait_for_link() further up in the file, as it's going to
be used by upcoming additional code in the driver."

Best regards,

Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering

Powered by blists - more mailing lists