linux-kernel - Re: [PATCH] habanalabs: Fix memleak in hl_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFCwf13k0Si+NvF2NXNEhXL2oG+ARtv=rCcXtuOwwNm7wH1AJg@mail.gmail.com>
Date:   Tue, 29 Dec 2020 23:30:20 +0200
From:   Oded Gabbay <oded.gabbay@...il.com>
To:     Dinghao Liu <dinghao.liu@....edu.cn>
Cc:     kjlu@....edu, Oded Gabbay <ogabbay@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Tomer Tayar <ttayar@...ana.ai>,
        Omer Shpigelman <oshpigelman@...ana.ai>,
        Ofir Bitton <obitton@...ana.ai>,
        Moti Haimovski <mhaimovski@...ana.ai>,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] habanalabs: Fix memleak in hl_device_reset

On Sat, Dec 26, 2020 at 9:32 AM Dinghao Liu <dinghao.liu@....edu.cn> wrote:
>
> When kzalloc() fails, we should execute hl_mmu_fini()
> to release the MMU module. It's the same when
> hl_ctx_init() fails.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>
> ---
>  drivers/misc/habanalabs/common/device.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/misc/habanalabs/common/device.c b/drivers/misc/habanalabs/common/device.c
> index 5871162a8442..e5028890ead1 100644
> --- a/drivers/misc/habanalabs/common/device.c
> +++ b/drivers/misc/habanalabs/common/device.c
> @@ -1092,6 +1092,7 @@ int hl_device_reset(struct hl_device *hdev, bool hard_reset,
>                                                 GFP_KERNEL);
>                 if (!hdev->kernel_ctx) {
>                         rc = -ENOMEM;
> +                       hl_mmu_fini(hdev);
>                         goto out_err;
>                 }
>
> @@ -1103,6 +1104,7 @@ int hl_device_reset(struct hl_device *hdev, bool hard_reset,
>                                 "failed to init kernel ctx in hard reset\n");
>                         kfree(hdev->kernel_ctx);
>                         hdev->kernel_ctx = NULL;
> +                       hl_mmu_fini(hdev);
>                         goto out_err;
>                 }
>         }
> --
> 2.17.1
>
Thanks!

This patch is:
Reviewed-by: Oded Gabbay <ogabbay@...nel.org>

Applied to -fixes
Oded