linux-kernel - Re: [PATCH] DTS: ARM: gta04: SPI panel chip select is active low

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201230084830.GG26857@atomide.com>
Date:   Wed, 30 Dec 2020 10:48:30 +0200
From:   Tony Lindgren <tony@...mide.com>
To:     "H. Nikolaus Schaller" <hns@...delico.com>
Cc:     Benoît Cousson <bcousson@...libre.com>,
        Rob Herring <robh+dt@...nel.org>, linux-omap@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        letux-kernel@...nphoenux.org,
        Andreas Kemnade <andreas@...nade.info>,
        kernel@...a-handheld.com, stable@...r.kernel.org
Subject: Re: [PATCH] DTS: ARM: gta04: SPI panel chip select is active low

* H. Nikolaus Schaller <hns@...delico.com> [201223 12:33]:
> With the arrival of
> 
> commit 2fee9583198eb9 ("spi: dt-bindings: clarify CS behavior for spi-cs-high and gpio descriptors")
> 
> it was clarified what the proper state for cs-gpios should be, even if the
> flag is ignored. The driver code is doing the right thing since
> 
> 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")
> 
> The chip-select of the td028ttec1 panel is active-low, so we must omit spi-cs-high;
> attribute (already removed by separate patch) and should now use GPIO_ACTIVE_LOW for
> the client device description to be fully consistent.

Applying into fixes thanks.

Tony