lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 30 Dec 2020 10:22:43 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Pavel Machek <pavel@....cz>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Harry Wentland <harry.wentland@....com>,
        Arnd Bergmann <arnd@...db.de>,
        Alex Deucher <alexander.deucher@....com>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 5.4 099/453] drm/amdgpu: fix build_coefficients() argument

On Tue, Dec 29, 2020 at 06:58:19PM +0100, Pavel Machek wrote:
> Hi!
> 
> > From: Arnd Bergmann <arnd@...db.de>
> > 
> > [ Upstream commit dbb60031dd0c2b85f10ce4c12ae604c28d3aaca4 ]
> > 
> > gcc -Wextra warns about a function taking an enum argument
> > being called with a bool:
> > 
> > drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.c: In function 'apply_degamma_for_user_regamma':
> > drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.c:1617:29: warning: implicit conversion from 'enum <anonymous>' to 'enum dc_transfer_func_predefined' [-Wenum-conversion]
> >  1617 |  build_coefficients(&coeff, true);
> > 
> > It appears that a patch was added using the old calling conventions
> > after the type was changed, and the value should actually be 0
> > (TRANSFER_FUNCTION_SRGB) here instead of 1 (true).
> 
> Yeah, but 4.19 still uses bool there, so this actually introduces a
> bug.
> 
> Please drop.

Now dropped, thanks.

greg k-h

Powered by blists - more mailing lists