lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 Dec 2020 11:44:19 +0200 From: Eli Cohen <elic@...dia.com> To: Jason Wang <jasowang@...hat.com> CC: <mst@...hat.com>, <eperezma@...hat.com>, <kvm@...r.kernel.org>, <virtualization@...ts.linux-foundation.org>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <lulu@...hat.com>, <eli@...lanox.com>, <lingshan.zhu@...el.com>, <rob.miller@...adcom.com>, <stefanha@...hat.com>, <sgarzare@...hat.com> Subject: Re: [PATCH 07/21] vdpa: multiple address spaces support On Wed, Dec 30, 2020 at 12:04:30PM +0800, Jason Wang wrote: > > On 2020/12/29 下午3:28, Eli Cohen wrote: > > > @@ -43,6 +43,8 @@ struct vdpa_vq_state { > > > * @index: device index > > > * @features_valid: were features initialized? for legacy guests > > > * @nvqs: the number of virtqueues > > > + * @ngroups: the number of virtqueue groups > > > + * @nas: the number of address spaces > > I am not sure these can be categorised as part of the state of the VQ. > > It's more of a property so maybe we can have a callback to get the > > properties of the VQ? > > > Or maybe there's a misunderstanding of the patch. > Yes, I misinterpreted the hunk. No issue here. > Those two attributes belongs to vdpa_device instead of vdpa_vq_state > actually. > > Thanks >
Powered by blists - more mailing lists