linux-kernel - Re: [PATCH v2] tty: resolve loopback wait problem for aging serial port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <X+x3Soqf6D6XzuxY@kroah.com>
Date:   Wed, 30 Dec 2020 13:49:14 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     zhangqiumiao1@...wei.com
Cc:     jirislaby@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] tty: resolve loopback wait problem for aging serial
 port

On Wed, Dec 30, 2020 at 08:39:06PM +0800, zhangqiumiao1@...wei.com wrote:
> From: Qiumiao Zhang <zhangqiumiao1@...wei.com>
> 
> Because serial port is low-speed device, serial port writing will be suspended
> when the buffer of driver layer is full due to serial port aging. The concrete
> representation is n_tty_write blocking in the process of wait_woken, the process
> of writing serial port exists without feedback, and becomes a zombie process.
> So for serial port, set the timeout value of wait_woken function to 60s. Wake up
> and flush the buffer after timeout.
> 
> Signed-off-by: Qiumiao Zhang <zhangqiumiao1@...wei.com>
> ---
>  drivers/tty/n_tty.c | 15 ++++++++++++++-
>  1 file changed, 14 insertions(+), 1 deletion(-)

What changed from v1?  Always put that below the --- line as the
documentation asks you to do so.

Please fix up and submit a v3.

thanks,

greg k-h