linux-kernel - Re: inconsistent lock state in ila_xlat_nl_cmd_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 29 Dec 2020 18:16:25 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     syzbot <syzbot+eaaf6c4a6a8cb1869d86@...kaller.appspotmail.com>,
        David Miller <davem@...emloft.net>,
        Greg KH <gregkh@...uxfoundation.org>,
        Kees Cook <keescook@...omium.org>,
        Kirill Tkhai <ktkhai@...tuozzo.com>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        syzkaller-bugs <syzkaller-bugs@...glegroups.com>,
        Tom Herbert <tom@...bertland.com>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>
Subject: Re: inconsistent lock state in ila_xlat_nl_cmd_add_mapping

On Tue, 29 Dec 2020 17:52:56 -0800 Cong Wang wrote:
> On Tue, Dec 29, 2020 at 5:39 PM Jakub Kicinski <kuba@...nel.org> wrote:
> >
> > On Mon, 13 Aug 2018 21:40:03 -0700 syzbot wrote:  
> > > Hello,
> > >
> > > syzbot found the following crash on:
> > >
> > > HEAD commit:    78cbac647e61 Merge branch 'ip-faster-in-order-IP-fragments'
> > > git tree:       net-next
> > > console output: https://syzkaller.appspot.com/x/log.txt?x=14df4828400000
> > > kernel config:  https://syzkaller.appspot.com/x/.config?x=9100338df26ab75
> > > dashboard link: https://syzkaller.appspot.com/bug?extid=eaaf6c4a6a8cb1869d86
> > > compiler:       gcc (GCC) 8.0.1 20180413 (experimental)
> > > syzkaller repro:https://syzkaller.appspot.com/x/repro.syz?x=13069ad2400000
> > >
> > > IMPORTANT: if you fix the bug, please add the following tag to the commit:
> > > Reported-by: syzbot+eaaf6c4a6a8cb1869d86@...kaller.appspotmail.com  
> >
> > #syz invalid
> >
> > Hard to track down what fixed this, but the lockdep splat is mixing up
> > locks from two different hashtables, so there was never a real issue
> > here.  
> 
> This one is probably fixed by:
> 
> commit ff93bca769925a2d8fd7f910cdf543d992e17f07
> Author: Cong Wang <xiyou.wangcong@...il.com>
> Date:   Tue Aug 14 15:21:31 2018 -0700
> 
>     ila: make lockdep happy again
> 
> given the time of last reproducing...

Ah, yes, matches perfectly! I didn't look for fixes in spinlock.h.

Thanks!