linux-kernel - [PATCH] irqchip/gic: remove a if in gic_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1609295441-36288-1-git-send-email-yejune.deng@gmail.com>
Date:   Wed, 30 Dec 2020 10:30:41 +0800
From:   Yejune Deng <yejune.deng@...il.com>
To:     tglx@...utronix.de, maz@...nel.org
Cc:     linux-kernel@...r.kernel.org, yejune.deng@...il.com
Subject: [PATCH] irqchip/gic: remove a if in gic_of_setup()

There is two function gic_of_init() and gic_of_init_child() called
gic_of_setup(),both gic and node never fail,so remove
if (!gic || !node) is safe.

Signed-off-by: Yejune Deng <yejune.deng@...il.com>
---
 drivers/irqchip/irq-gic.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
index b1d9c22..a65678f0 100644
--- a/drivers/irqchip/irq-gic.c
+++ b/drivers/irqchip/irq-gic.c
@@ -1380,9 +1380,6 @@ static bool gic_check_eoimode(struct device_node *node, void __iomem **base)
 
 static int gic_of_setup(struct gic_chip_data *gic, struct device_node *node)
 {
-	if (!gic || !node)
-		return -EINVAL;
-
 	gic->raw_dist_base = of_iomap(node, 0);
 	if (WARN(!gic->raw_dist_base, "unable to map gic dist registers\n"))
 		goto error;
-- 
1.9.1