linux-kernel - Re: [PATCH] iio: adc: stm32-dfsdm: Remove redundant null check before clk_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201230154107.4b301aed@archlinux>
Date:   Wed, 30 Dec 2020 15:41:07 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Xu Wang <vulab@...as.ac.cn>
Cc:     lars@...afoo.de, pmeerw@...erw.net, mcoquelin.stm32@...il.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: stm32-dfsdm: Remove redundant null check
 before clk_disable_unprepare

On Fri, 18 Dec 2020 09:41:45 +0000
Xu Wang <vulab@...as.ac.cn> wrote:

> ecause clk_disable_unprepare() already checked NULL clock parameter,
> so the additional check is unnecessary, just remove it.
Please resend, making sure to cc linux-iio@...r.kernel.org

Thanks,

Jonathan

> 
> Signed-off-by: Xu Wang <vulab@...as.ac.cn>
> ---
>  drivers/iio/adc/stm32-dfsdm-core.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c
> index 42a7377704a4..bb925a11c8ae 100644
> --- a/drivers/iio/adc/stm32-dfsdm-core.c
> +++ b/drivers/iio/adc/stm32-dfsdm-core.c
> @@ -117,8 +117,7 @@ static void stm32_dfsdm_clk_disable_unprepare(struct stm32_dfsdm *dfsdm)
>  {
>  	struct dfsdm_priv *priv = to_stm32_dfsdm_priv(dfsdm);
>  
> -	if (priv->aclk)
> -		clk_disable_unprepare(priv->aclk);
> +	clk_disable_unprepare(priv->aclk);
>  	clk_disable_unprepare(priv->clk);
>  }
>