linux-kernel - Re: [BUG] checkpatch: non-standard types cannot be declared after '}'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <62817e31-d217-5641-f103-895843646524@jan-o-sch.net>
Date:   Wed, 30 Dec 2020 21:06:17 +0100
From:   Jan Schlien <list.lkml@...-o-sch.net>
To:     Joe Perches <joe@...ches.com>, Andy Whitcroft <apw@...onical.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [BUG] checkpatch: non-standard types cannot be declared after '}'

On 30.12.20 19:52, Joe Perches wrote:
> On Wed, 2020-12-30 at 14:36 +0100, Jan Schlien wrote:
>> Hi,
>>
>> I found some odd behavior of checkpatch.pl, which I'm currently using
>> for own projects outside the kernel, but I verified that kernel patches
>> can be affected as well.
> 
> Hello Jan.
> 
> I've had this patch locally for awhile that I believe fixes this
> and another issue ($stat blocks can start with a close brace).
> 
> I've been waiting for Andy to review it in case there's some other
> parsing problem associated with it.

Hello Joe,

Thanks for digging that out promptly. Looks good to me and also fixes my
issue. I cannot argue that I fully understand that function, so no
review but you can add

Tested-by: Jan Schlien <list.lkml@...-o-sch.net>

if you like.

Best,
-Jan