lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 31 Dec 2020 07:22:22 +0800
From:   kernel test robot <lkp@...el.com>
To:     Timon Baetz <timon.baetz@...tonmail.com>,
        Krzysztof Kozlowski <krzk@...nel.org>
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Lee Jones <lee.jones@...aro.org>,
        Sebastian Reichel <sre@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 3/8] power: supply: max8997_charger: Set CHARGER
 current limit

Hi Timon,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on regulator/for-next]
[also build test ERROR on pinctrl-samsung/for-next krzk/for-next v5.11-rc1 next-20201223]
[cannot apply to robh/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Timon-Baetz/extcon-max8997-Add-CHGINS-and-CHGRM-interrupt-handling/20201231-045812
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
config: arm-randconfig-r004-20201230 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 3c0d36f977d9e012b245c796ddc8596ac3af659b)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/0day-ci/linux/commit/3a597219bbfc1f9a0b65b9662b7b95bbb7cf728f
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Timon-Baetz/extcon-max8997-Add-CHGINS-and-CHGRM-interrupt-handling/20201231-045812
        git checkout 3a597219bbfc1f9a0b65b9662b7b95bbb7cf728f
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/power/supply/max8997_charger.c:261:9: error: implicit declaration of function 'devm_extcon_register_notifier_all' [-Werror,-Wimplicit-function-declaration]
                   ret = devm_extcon_register_notifier_all(&pdev->dev, charger->edev,
                         ^
   drivers/power/supply/max8997_charger.c:261:9: note: did you mean 'devm_extcon_register_notifier'?
   include/linux/extcon.h:263:19: note: 'devm_extcon_register_notifier' declared here
   static inline int devm_extcon_register_notifier(struct device *dev,
                     ^
   1 error generated.


vim +/devm_extcon_register_notifier_all +261 drivers/power/supply/max8997_charger.c

   165	
   166	static int max8997_battery_probe(struct platform_device *pdev)
   167	{
   168		int ret = 0;
   169		struct charger_data *charger;
   170		struct max8997_dev *iodev = dev_get_drvdata(pdev->dev.parent);
   171		struct i2c_client *i2c = iodev->i2c;
   172		struct max8997_platform_data *pdata = iodev->pdata;
   173		struct power_supply_config psy_cfg = {};
   174	
   175		if (!pdata) {
   176			dev_err(&pdev->dev, "No platform data supplied.\n");
   177			return -EINVAL;
   178		}
   179	
   180		if (pdata->eoc_mA) {
   181			int val = (pdata->eoc_mA - 50) / 10;
   182			if (val < 0)
   183				val = 0;
   184			if (val > 0xf)
   185				val = 0xf;
   186	
   187			ret = max8997_update_reg(i2c, MAX8997_REG_MBCCTRL5,
   188					val << ITOPOFF_SHIFT, ITOPOFF_MASK);
   189			if (ret < 0) {
   190				dev_err(&pdev->dev, "Cannot use i2c bus.\n");
   191				return ret;
   192			}
   193		}
   194		switch (pdata->timeout) {
   195		case 5:
   196			ret = max8997_update_reg(i2c, MAX8997_REG_MBCCTRL1,
   197					0x2 << TFCH_SHIFT, TFCH_MASK);
   198			break;
   199		case 6:
   200			ret = max8997_update_reg(i2c, MAX8997_REG_MBCCTRL1,
   201					0x3 << TFCH_SHIFT, TFCH_MASK);
   202			break;
   203		case 7:
   204			ret = max8997_update_reg(i2c, MAX8997_REG_MBCCTRL1,
   205					0x4 << TFCH_SHIFT, TFCH_MASK);
   206			break;
   207		case 0:
   208			ret = max8997_update_reg(i2c, MAX8997_REG_MBCCTRL1,
   209					0x7 << TFCH_SHIFT, TFCH_MASK);
   210			break;
   211		default:
   212			dev_err(&pdev->dev, "incorrect timeout value (%d)\n",
   213					pdata->timeout);
   214			return -EINVAL;
   215		}
   216		if (ret < 0) {
   217			dev_err(&pdev->dev, "Cannot use i2c bus.\n");
   218			return ret;
   219		}
   220	
   221		charger = devm_kzalloc(&pdev->dev, sizeof(*charger), GFP_KERNEL);
   222		if (!charger)
   223			return -ENOMEM;
   224	
   225		platform_set_drvdata(pdev, charger);
   226	
   227		charger->dev = &pdev->dev;
   228		charger->iodev = iodev;
   229	
   230		psy_cfg.drv_data = charger;
   231	
   232		charger->battery = devm_power_supply_register(&pdev->dev,
   233							 &max8997_battery_desc,
   234							 &psy_cfg);
   235		if (IS_ERR(charger->battery)) {
   236			dev_err(&pdev->dev, "failed: power supply register\n");
   237			return PTR_ERR(charger->battery);
   238		}
   239	
   240		charger->reg = devm_regulator_get_optional(&pdev->dev, "charger");
   241		if (IS_ERR(charger->reg)) {
   242			if (PTR_ERR(charger->reg) == -EPROBE_DEFER)
   243				return -EPROBE_DEFER;
   244			dev_info(&pdev->dev, "couldn't get charger regulator\n");
   245		}
   246		charger->edev = extcon_get_edev_by_phandle(&pdev->dev, 0);
   247		if (IS_ERR(charger->edev)) {
   248			if (PTR_ERR(charger->edev) == -EPROBE_DEFER)
   249				return -EPROBE_DEFER;
   250			dev_info(charger->dev, "couldn't get extcon device\n");
   251		}
   252	
   253		if (!IS_ERR(charger->reg) && !IS_ERR(charger->edev)) {
   254			INIT_WORK(&charger->extcon_work, max8997_battery_extcon_evt_worker);
   255			ret = devm_add_action(&pdev->dev, max8997_battery_extcon_evt_stop_work, charger);
   256			if (ret) {
   257				dev_err(&pdev->dev, "failed to add extcon evt stop action: %d\n", ret);
   258				return ret;
   259			}
   260			charger->extcon_nb.notifier_call = max8997_battery_extcon_evt;
 > 261			ret = devm_extcon_register_notifier_all(&pdev->dev, charger->edev,
   262								&charger->extcon_nb);
   263			if (ret) {
   264				dev_err(&pdev->dev, "failed to register extcon notifier\n");
   265				return ret;
   266			};
   267		}
   268	
   269		return 0;
   270	}
   271	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (20871 bytes)

Powered by blists - more mailing lists