lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 Dec 2020 08:02:44 +0100 From: Borislav Petkov <bp@...en8.de> To: Zhenzhong Duan <zhenzhong.duan@...il.com> Cc: linux-kernel@...r.kernel.org, zhongjiang@...wei.com, joe@...ches.com, konrad.wilk@...cle.com, tglx@...utronix.de, mingo@...hat.com, iommu@...ts.linux-foundation.org, dwmw2@...radead.org, baolu.lu@...ux.intel.com, joro@...tes.org, will@...nel.org Subject: Re: [PATCH] x86/iommu: Fix two minimal issues in check_iommu_entries() On Wed, Dec 23, 2020 at 02:24:12PM +0800, Zhenzhong Duan wrote: > check_iommu_entries() checks for cyclic dependency in iommu entries > and fixes the cyclic dependency by setting x->depend to NULL. But > this repairing isn't correct if q is in front of p, there will be > "EXECUTION ORDER INVALID!" report following. Fix it by NULLing > whichever in the front. When does "q is in front of p" happen? How does it happen? > The second issue is about the report of exectuion order reverse, > the order is reversed incorrectly in the report, fix it. I have no clue what that means. Plese structure your commit message something like this: Problem is A. It happens because of B. Fix it by doing C. (Potentially do D). For more detailed info, see Documentation/process/submitting-patches.rst, Section "2) Describe your changes". Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette
Powered by blists - more mailing lists