| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20201231155715.GA1852831@robh.at.kernel.org>
Date: Thu, 31 Dec 2020 08:57:15 -0700
From: Rob Herring <robh@...nel.org>
To: Nick Fan <Nick.Fan@...iatek.com>
Cc: Matthias Brugger <matthias.bgg@...il.com>,
David Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
srv_heupstream@...iatek.com, linux-mediatek@...ts.infradead.org,
Project_Global_Chrome_Upstream_Group@...iatek.com,
linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: Convert Arm Mali Valhall GPU to DT
schema
On Thu, Dec 24, 2020 at 08:31:18PM +0800, Nick Fan wrote:
> Convert the Arm Valhall GPU binding to DT schema format.
Convert? There's no existing binding.
>
> Define a compatible string for the Mali Valhall GPU
> for Mediatek's SoC platform.
>
> Signed-off-by: Nick Fan <Nick.Fan@...iatek.com>
> ---
> .../bindings/gpu/arm,mali-valhall.yaml | 252 ++++++++++++++++++
> 1 file changed, 252 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpu/arm,mali-valhall.yaml
>
> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-valhall.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-valhall.yaml
> new file mode 100644
> index 000000000000..3dba202bec95
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-valhall.yaml
> @@ -0,0 +1,252 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (c) 2020 MediaTek Inc.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpu/arm,mali-vallhall.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ARM Mali Valhall GPU
> +
> +maintainers:
> + - Rob Herring <robh@...nel.org>
> +
> +properties:
> + $nodename:
> + pattern: '^gpu@[a-f0-9]+$'
> +
> + compatible:
> + items:
> + - enum:
> + - mediatek,mt8192-mali
> + - const: arm,mali-valhall # Mali Valhall GPU model/revision is fully discoverable
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + items:
> + - description: GPU interrupt
> + - description: MMU interrupt
> + - description: Job interrupt
> +
> + interrupt-names:
> + items:
> + - const: gpu
> + - const: mmu
> + - const: job
> +
> + clocks:
> + minItems: 1
> +
> + power-domains:
> + minItems: 1
> + maxItems: 5
> +
> + mali-supply: true
> + sram-supply: true
> +
> + operating-points-v2: true
> +
> + "#cooling-cells":
> + const: 2
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - interrupt-names
> + - clocks
> +
> +additionalProperties: false
> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: mediatek,mt8192-mali
> + then:
> + properties:
> + sram-supply: true
No need for this line.
> + power-domains:
> + description:
> + List of phandle and PM domain specifier as documented in
> + Documentation/devicetree/bindings/power/power_domain.txt
No need re-describe a common property.
> + minItems: 5
> + maxItems: 5
blank line between DT properties.
> + power-domain-names:
> + items:
> + - const: core0
> + - const: core1
> + - const: core2
> + - const: core3
> + - const: core4
> +
> + required:
> + - sram-supply
> + - power-domains
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + gpu@...00000 {
> + compatible = "mediatek,mt8192-mali", "arm,mali-valhall";
> + reg = <0x13000000 0x4000>;
> + interrupts =
> + <GIC_SPI 363 IRQ_TYPE_LEVEL_HIGH 0>,
> + <GIC_SPI 364 IRQ_TYPE_LEVEL_HIGH 0>,
> + <GIC_SPI 365 IRQ_TYPE_LEVEL_HIGH 0>;
> + interrupt-names =
> + "gpu",
> + "mmu",
> + "job";
> +
> + clocks = <&mfgcfg 0>;
> +
> + power-domains =
> + <&scpsys 4>,
> + <&scpsys 5>,
> + <&scpsys 6>,
> + <&scpsys 7>,
> + <&scpsys 8>;
> +
> + operating-points-v2 = <&gpu_opp_table>;
> + mali-supply = <&mt6315_7_vbuck1>;
> + sram-supply = <&mt6359_vsram_others_ldo_reg>;
> + };
> +
> + gpu_opp_table: opp_table0 {
Make this a child of the gpu node. Node name should be just 'opp-table'.
> + compatible = "operating-points-v2";
> + opp-shared;
> +
> + opp-358000000 {
> + opp-hz = /bits/ 64 <358000000>;
> + opp-hz-real = /bits/ 64 <358000000>,
I don't recall this being an OPP property.
> + /bits/ 64 <358000000>;
> + opp-microvolt = <606250>,
> + <750000>;
> + };
> +
> + opp-399000000 {
> + opp-hz = /bits/ 64 <399000000>;
> + opp-hz-real = /bits/ 64 <399000000>,
> + /bits/ 64 <399000000>;
> + opp-microvolt = <618750>,
> + <750000>;
> + };
> +
> + opp-440000000 {
> + opp-hz = /bits/ 64 <440000000>;
> + opp-hz-real = /bits/ 64 <440000000>,
> + /bits/ 64 <440000000>;
> + opp-microvolt = <631250>,
> + <750000>;
> + };
> +
> + opp-482000000 {
> + opp-hz = /bits/ 64 <482000000>;
> + opp-hz-real = /bits/ 64 <482000000>,
> + /bits/ 64 <482000000>;
> + opp-microvolt = <643750>,
> + <750000>;
> + };
> +
> + opp-523000000 {
> + opp-hz = /bits/ 64 <523000000>;
> + opp-hz-real = /bits/ 64 <523000000>,
> + /bits/ 64 <523000000>;
> + opp-microvolt = <656250>,
> + <750000>;
> + };
> +
> + opp-564000000 {
> + opp-hz = /bits/ 64 <564000000>;
> + opp-hz-real = /bits/ 64 <564000000>,
> + /bits/ 64 <564000000>;
> + opp-microvolt = <668750>,
> + <750000>;
> + };
> +
> + opp-605000000 {
> + opp-hz = /bits/ 64 <605000000>;
> + opp-hz-real = /bits/ 64 <605000000>,
> + /bits/ 64 <605000000>;
> + opp-microvolt = <681250>,
> + <750000>;
> + };
> +
> + opp-647000000 {
> + opp-hz = /bits/ 64 <647000000>;
> + opp-hz-real = /bits/ 64 <647000000>,
> + /bits/ 64 <647000000>;
> + opp-microvolt = <693750>,
> + <750000>;
> + };
> +
> + opp-688000000 {
> + opp-hz = /bits/ 64 <688000000>;
> + opp-hz-real = /bits/ 64 <688000000>,
> + /bits/ 64 <688000000>;
> + opp-microvolt = <706250>,
> + <750000>;
> + };
> +
> + opp-724000000 {
> + opp-hz = /bits/ 64 <724000000>;
> + opp-hz-real = /bits/ 64 <724000000>,
> + /bits/ 64 <724000000>;
> + opp-microvolt = <725000>,
> + <750000>;
> + };
> +
> + opp-760000000 {
> + opp-hz = /bits/ 64 <760000000>;
> + opp-hz-real = /bits/ 64 <760000000>,
> + /bits/ 64 <760000000>;
> + opp-microvolt = <743750>,
> + <750000>;
> + };
> +
> + opp-795000000 {
> + opp-hz = /bits/ 64 <795000000>;
> + opp-hz-real = /bits/ 64 <795000000>,
> + /bits/ 64 <795000000>;
> + opp-microvolt = <762500>,
> + <762500>;
> + };
> +
> + opp-831000000 {
> + opp-hz = /bits/ 64 <831000000>;
> + opp-hz-real = /bits/ 64 <831000000>,
> + /bits/ 64 <831000000>;
> + opp-microvolt = <781250>,
> + <781250>;
> + };
> +
> + opp-855000000 {
> + opp-hz = /bits/ 64 <855000000>;
> + opp-hz-real = /bits/ 64 <855000000>,
> + /bits/ 64 <855000000>;
> + opp-microvolt = <793750>,
> + <793750>;
> + };
> +
> + opp-902000000 {
> + opp-hz = /bits/ 64 <902000000>;
> + opp-hz-real = /bits/ 64 <902000000>,
> + /bits/ 64 <902000000>;
> + opp-microvolt = <818750>,
> + <818750>;
> + };
> +
> + opp-950000000 {
> + opp-hz = /bits/ 64 <950000000>;
> + opp-hz-real = /bits/ 64 <950000000>,
> + /bits/ 64 <950000000>;
> + opp-microvolt = <843750>,
> + <843750>;
> + };
> + };
> +...
> --
> 2.18.0
>
Powered by blists - more mailing lists