linux-kernel - Re: [PATCH] pinctrl: nomadik: remove an unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 Dec 2020 20:07:07 -0600
From:   Andrew Halaney <ajhalaney@...il.com>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Arnd Bergmann <arnd@...db.de>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Jacopo Mondi <jacopo+renesas@...ndi.org>,
        Ding Xiang <dingxiang@...s.chinamobile.com>,
        Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
        linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: nomadik: remove an unused variable

On Wed, Dec 30, 2020 at 04:46:17PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> A recent patch added a local variable twice:
> 
> drivers/pinctrl/nomadik/pinctrl-nomadik.c:953:8: error: unused variable 'wake' [-Werror,-Wunused-variable]
> 
> Remove the unused outer declaration
> 
> Fixes: f3925032d7fd ("pinctrl: nomadik: Use irq_has_action()")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> index d4ea10803fd9..abfe11c7b49f 100644
> --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> @@ -949,7 +949,6 @@ static void nmk_gpio_dbg_show_one(struct seq_file *s,
>  	} else {
>  		int irq = chip->to_irq(chip, offset);
>  		const int pullidx = pull ? 1 : 0;
> -		bool wake;
>  		int val;
>  		static const char * const pulls[] = {
>  			"none        ",
> -- 
> 2.29.2
> 

Got rid of the warning for me, I don't have hardware to test on but I
don't think that's necessary for this.

Tested-by: Andrew Halaney <ajhalaney@...il.com>
Reviewed-by: Andrew Halaney <ajhalaney@...il.com>

Thanks,
Andrew