linux-kernel - Re: [PATCH] ocfs2: Remove redundant conditional before iput

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 31 Dec 2020 12:33:14 +0800
From:   Joseph Qi <joseph.qi@...ux.alibaba.com>
To:     Yi Li <yili@...hong.com>, akpm@...ux-foundation.org
Cc:     mark@...heh.com, yilikernel@...il.com, ocfs2-devel@....oracle.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ocfs2: Remove redundant conditional before iput



On 12/31/20 12:05 PM, Yi Li wrote:
> iput handles NULL pointers gracefully, so there's no need to
> check the pointer before the call.
> 
> Signed-off-by: Yi Li <yili@...hong.com>

Acked-by: Joseph Qi <joseph.qi@...ux.alibaba.com>
> ---
>  fs/ocfs2/super.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
> index 2febc76e9de7..079f8826993e 100644
> --- a/fs/ocfs2/super.c
> +++ b/fs/ocfs2/super.c
> @@ -973,8 +973,6 @@ static void ocfs2_disable_quotas(struct ocfs2_super *osb)
>  		 * quota files */
>  		dquot_disable(sb, type, DQUOT_USAGE_ENABLED |
>  					DQUOT_LIMITS_ENABLED);
> -		if (!inode)
> -			continue;
>  		iput(inode);
>  	}
>  }
>