lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 1 Jan 2021 09:18:48 +0100 From: Greg KH <gregkh@...uxfoundation.org> To: Gao Yan <gao.yanB@....com> Cc: jirislaby@...nel.org, paulus@...ba.org, davem@...emloft.net, kuba@...nel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] [v2]net:ppp: remove disc_data_lock in ppp line discipline On Fri, Jan 01, 2021 at 11:37:18AM +0800, Gao Yan wrote: > In tty layer, it provides tty->ldisc_sem to protect all tty_ldisc_ops > including ppp_sync_ldisc. So I think tty->ldisc_sem can also > protect tty->disc_data, and the disc_data_lock is not necessary. > > Signed-off-by: Gao Yan <gao.yanB@....com> > --- > drivers/net/ppp/ppp_async.c | 11 ++--------- > drivers/net/ppp/ppp_synctty.c | 12 ++---------- > 2 files changed, 4 insertions(+), 19 deletions(-) What changed from v1? And how did you test this? Why remove this lock, is it causing problems somewhere for it to be here? thanks, greg k-h
Powered by blists - more mailing lists