lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 1 Jan 2021 15:27:57 +0100 From: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de> To: Thomas Gleixner <tglx@...utronix.de>, LKML <linux-kernel@...r.kernel.org> Cc: Peter Zijlstra <peterz@...radead.org>, Frederic Weisbecker <frederic@...nel.org>, Paul McKenney <paulmck@...nel.org>, Sebastian Andrzej Siewior <bigeasy@...utronix.de>, Arnd Bergmann <arnd@...db.de>, Yoshinori Sato <ysato@...rs.sourceforge.jp>, Rich Felker <dalias@...c.org>, linux-sh@...r.kernel.org, "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>, Helge Deller <deller@....de>, linux-parisc@...r.kernel.org, Jeff Dike <jdike@...toit.com>, Richard Weinberger <richard@....at>, Anton Ivanov <anton.ivanov@...bridgegreys.com>, linux-um@...ts.infradead.org, Russell King <linux@...linux.org.uk>, Marc Zyngier <maz@...nel.org>, Valentin Schneider <valentin.schneider@....com>, linux-arm-kernel@...ts.infradead.org, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org> Subject: Re: [patch 02/19] sh: Get rid of nmi_count() Hello Thomas! On 11/13/20 3:02 PM, Thomas Gleixner wrote: > nmi_count() is a historical leftover and SH is the only user. Replace it > with regular per cpu accessors. > > Signed-off-by: Thomas Gleixner <tglx@...utronix.de> > Cc: Yoshinori Sato <ysato@...rs.sourceforge.jp> > Cc: Rich Felker <dalias@...c.org> > Cc: linux-sh@...r.kernel.org > --- > arch/sh/kernel/irq.c | 2 +- > arch/sh/kernel/traps.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > --- a/arch/sh/kernel/irq.c > +++ b/arch/sh/kernel/irq.c > @@ -44,7 +44,7 @@ int arch_show_interrupts(struct seq_file > > seq_printf(p, "%*s: ", prec, "NMI"); > for_each_online_cpu(j) > - seq_printf(p, "%10u ", nmi_count(j)); > + seq_printf(p, "%10u ", per_cpu(irq_stat.__nmi_count, j); > seq_printf(p, " Non-maskable interrupts\n"); > > seq_printf(p, "%*s: %10u\n", prec, "ERR", atomic_read(&irq_err_count)); > --- a/arch/sh/kernel/traps.c > +++ b/arch/sh/kernel/traps.c > @@ -186,7 +186,7 @@ BUILD_TRAP_HANDLER(nmi) > arch_ftrace_nmi_enter(); > > nmi_enter(); > - nmi_count(cpu)++; > + this_cpu_inc(irq_stat.__nmi_count); > > switch (notify_die(DIE_NMI, "NMI", regs, 0, vec & 0xff, SIGINT)) { > case NOTIFY_OK: > Just booted my SH7785LCR board with a kernel based on Linus' latest tree and can confirm that this change does not cause any regressions. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaubitz@...ian.org `. `' Freie Universitaet Berlin - glaubitz@...sik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Powered by blists - more mailing lists