[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Thu, 31 Dec 2020 17:55:00 -0800
From: Joe Perches <joe@...ches.com>
To: Jonathan Neuschäfer <j.neuschaefer@....net>,
Andy Whitcroft <apw@...onical.com>
Cc: Rob Herring <robh@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: checkpatch.pl: Bogus case of DT_SPLIT_BINDING_PATCH
On Thu, 2020-12-31 at 23:04 +0100, Jonathan Neuschäfer wrote:
> Hi,
>
> I've encountered a case where the DT_SPLIT_BINDING_PATCH warning was
> emitted even though I didn't change anything outside of Documentation/
> devicetree/bindings. I just converted a binding from plain text to YAML.
Rob? Your code...
> Here's a transcript of checkpatch (from Linux 5.11-rc1)'s output:
>
> $ scripts/checkpatch.pl --strict patches-wpcm/0001-dt-bindings-arm-Convert-nuvoton-npcm750-binding-to-Y.patch
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #31:
> deleted file mode 100644
>
>
> WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
>
>
> WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
>
>
> total: 0 errors, 3 warnings, 0 checks, 21 lines checked
>
>
> NOTE: For some of the reported defects, checkpatch may be able to
> mechanically convert to the typical style using --fix or --fix-inplace.
>
>
> patches-wpcm/0001-dt-bindings-arm-Convert-nuvoton-npcm750-binding-to-Y.patch has style problems, please review.
>
>
> NOTE: If any of the errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
>
> I attached the patch, for reference.
>
>
> Best regards,
> Jonathan Neuschäfer
Powered by blists - more mailing lists