lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 3 Jan 2021 16:34:26 +0100 From: Bartosz Golaszewski <bgolaszewski@...libre.com> To: Linus Walleij <linus.walleij@...aro.org> Cc: Kent Gibson <warthog618@...il.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, kernel test robot <lkp@...el.com> Subject: Re: [PATCH] gpiolib: cdev: fix frame size warning in gpio_ioctl() On Sun, Dec 27, 2020 at 10:37 PM Linus Walleij <linus.walleij@...aro.org> wrote: > > On Sun, Dec 27, 2020 at 5:11 PM Kent Gibson <warthog618@...il.com> wrote: > > > The kernel test robot reports the following warning in [1]: > > > > drivers/gpio/gpiolib-cdev.c: In function 'gpio_ioctl': > > >>drivers/gpio/gpiolib-cdev.c:1437:1: warning: the frame size of 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=] > > > > Refactor gpio_ioctl() to handle each ioctl in its own helper function > > and so reduce the variables stored on the stack to those explicitly > > required to service the ioctl at hand. > > > > The lineinfo_get_v1() helper handles both the GPIO_GET_LINEINFO_IOCTL > > and GPIO_GET_LINEINFO_WATCH_IOCTL, as per the corresponding v2 > > implementation - lineinfo_get(). > > > > [1] https://lore.kernel.org/lkml/202012270910.VW3qc1ER-lkp@intel.com/ > > > > Fixes: aad955842d1c ("gpiolib: cdev: support GPIO_V2_GET_LINEINFO_IOCTL and GPIO_V2_GET_LINEINFO_WATCH_IOCTL") > > Reported-by: kernel test robot <lkp@...el.com> > > Signed-off-by: Kent Gibson <warthog618@...il.com> > > That's an interesting regression. > Anyway the kernel look better after than before the patch, so > Reviewed-by: Linus Walleij <linus.walleij@...aro.org> > > Bartosz will pick patches for Torvalds this kernel cycle. > > Yours, > Linus Walleij Applied with Linus' tag, thanks! Bart
Powered by blists - more mailing lists