linux-kernel - Re: [PATCH 1/1] dt-bindings: adc-keys.txt: clarify description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210103163806.GA4008983@robh.at.kernel.org>
Date:   Sun, 3 Jan 2021 09:38:06 -0700
From:   Rob Herring <robh@...nel.org>
To:     Heinrich Schuchardt <xypron.glpk@....de>
Cc:     devicetree@...r.kernel.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH 1/1] dt-bindings: adc-keys.txt: clarify description

On Tue, 22 Dec 2020 12:08:15 +0100, Heinrich Schuchardt wrote:
> The current description of ADC keys is not precise enough.
> 
> "when this key is pressed" leaves it open if a key is considered pressed
> below or above the threshold. This has led to confusion:
> drivers/input/keyboard/adc-keys.c ignores the meaning of thresholds and
> sets the key that is closest to press-threshold-microvolt.
> 
> This patch nails down the definitions and provides an interpretation of the
> supplied example.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@....de>
> ---
> I know that this file needs to be converted to YAML. But lets first get the
> text right.
> ---
>  .../devicetree/bindings/input/adc-keys.txt    | 22 +++++++++++++++++--
>  1 file changed, 20 insertions(+), 2 deletions(-)
> 

Acked-by: Rob Herring <robh@...nel.org>