lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sun, 3 Jan 2021 19:20:31 +0200
From:   Cristian Ciocaltea <cristian.ciocaltea@...il.com>
To:     Sebastian Reichel <sebastian.reichel@...labora.com>
Cc:     Lee Jones <lee.jones@...aro.org>, Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Andreas Färber <afaerber@...e.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-actions@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH v4 5/7] power: reset: Add poweroff driver for ATC260x
 PMICs

Hi Sebastian,

On Sun, Jan 03, 2021 at 04:26:31AM +0100, Sebastian Reichel wrote:
> Hi,
> 
> On Tue, Dec 29, 2020 at 07:31:20PM +0200, Cristian Ciocaltea wrote:
> > This driver provides poweroff and reboot support for a system through
> > the ATC2603C and ATC2609A chip variants of the Actions Semi ATC260x
> > family of PMICs.
> > 
> > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...il.com>
> > ---
> > Changes in v4:
> >  - None
> > 
> > Changes in v3:
> >  - Removed the unnecessary driver compatibles
> > 
> > [...]
> > +#include <linux/delay.h>
> > +#include <linux/mfd/atc260x/core.h>
> > +#include <linux/module.h>
> > +#include <linux/of.h>
> 
> There is no DT code in this driver?

Right, this line is not needed anymore, I will drop it and submit a new
patch revision.

> > +#include <linux/platform_device.h>
> > +#include <linux/power_supply.h>
> 
> power_supply.h? That's for chargers and battery fuel gauges.

That is only used for checking if the S4 mode is available - which
involves calling 'power_supply_is_system_supplied()'.

> > +#include <linux/reboot.h>
> > +#include <linux/regmap.h>
> 
> > [...]
> 
> Otherwise LGTM. I suppose I can cherry-pick this patch into
> my tree, or did I miss some dependencies?

I'm not really sure what is the recommended approach (if any) for
merging MFD drivers.

The only dependency is the PMIC core driver in patch 3/7, which is
handled in Kconfig through 'depends on MFD_ATC260X'.

So far, Mark applied the regulator driver patch to his tree, while
Dmitry suggested to merge the onkey driver through MFD. So I think both
approaches are fine.

@Lee: Do you have any preference or recommendation for handling this?

> -- Sebastian

Thanks for the review,
Cristi

Powered by blists - more mailing lists