linux-kernel - [PATCH] pldmfw: select CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20210103214339.1997223-1-arnd@kernel.org>
Date:   Sun,  3 Jan 2021 22:43:28 +0100
From:   Arnd Bergmann <arnd@...nel.org>
To:     Jacob Keller <jacob.e.keller@...el.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     Arnd Bergmann <arnd@...db.de>, Mark Brown <broonie@...nel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        "Steven Rostedt (VMware)" <rostedt@...dmis.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        linux-kernel@...r.kernel.org
Subject: [PATCH] pldmfw: select CONFIG_CRC32

From: Arnd Bergmann <arnd@...db.de>

Without CRC32, pldmfw fails to link:

arm-linux-gnueabi-ld: lib/pldmfw/pldmfw.o: in function `pldmfw_flash_image':
(.text+0x1028): undefined reference to `crc32_le'

Fixes: b8265621f488 ("Add pldmfw library for PLDM firmware update")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 lib/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/Kconfig b/lib/Kconfig
index 46806332a8cc..86dc0dcd6e0b 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -691,4 +691,5 @@ config GENERIC_LIB_DEVMEM_IS_ALLOWED
 
 config PLDMFW
 	bool
+	select CRC32
 	default n
-- 
2.29.2