linux-kernel - Re: [PATCH] dm zoned: select CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 3 Jan 2021 23:13:12 +0000
From:   Damien Le Moal <Damien.LeMoal@....com>
To:     Arnd Bergmann <arnd@...nel.org>, Alasdair Kergon <agk@...hat.com>,
        Mike Snitzer <snitzer@...hat.com>,
        "dm-devel@...hat.com" <dm-devel@...hat.com>,
        Song Liu <song@...nel.org>,
        Bart Van Assche <bvanassche@....org>,
        Hannes Reinecke <hare@...e.com>
CC:     Arnd Bergmann <arnd@...db.de>,
        "linux-raid@...r.kernel.org" <linux-raid@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dm zoned: select CONFIG_CRC32

On 2021/01/04 6:41, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Without crc32 support, this driver fails to link:
> 
> arm-linux-gnueabi-ld: drivers/md/dm-zoned-metadata.o: in function `dmz_write_sb':
> dm-zoned-metadata.c:(.text+0xe98): undefined reference to `crc32_le'
> arm-linux-gnueabi-ld: drivers/md/dm-zoned-metadata.o: in function `dmz_check_sb':
> dm-zoned-metadata.c:(.text+0x7978): undefined reference to `crc32_le'
> 
> Fixes: 3b1a94c88b79 ("dm zoned: drive-managed zoned block device target")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/md/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig
> index b7e2d9666614..a67b9ed3ca89 100644
> --- a/drivers/md/Kconfig
> +++ b/drivers/md/Kconfig
> @@ -622,6 +622,7 @@ config DM_ZONED
>  	tristate "Drive-managed zoned block device target support"
>  	depends on BLK_DEV_DM
>  	depends on BLK_DEV_ZONED
> +	select CRC32
>  	help
>  	  This device-mapper target takes a host-managed or host-aware zoned
>  	  block device and exposes most of its capacity as a regular block
> 

Reviewed-by: Damien Le Moal <damien.lemoal@....com>


-- 
Damien Le Moal
Western Digital Research