linux-kernel - Re: [PATCH net,stable v2] net: cdc_ncm: correct overhead in delayed_ndp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210104140058.34cb4111@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 4 Jan 2021 14:00:58 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jouni Seppänen <jks@....fi>
Cc:     Oliver Neukum <oliver@...kum.org>, linux-usb@...r.kernel.org,
        Bjørn Mork <bjorn@...k.no>,
        "David S. Miller" <davem@...emloft.net>,
        Enrico Mioso <mrkiko.rs@...il.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH net,stable v2] net: cdc_ncm: correct overhead in
 delayed_ndp_size

On Sun,  3 Jan 2021 22:23:09 +0200 Jouni Seppänen wrote:
>  	if (ctx->drvflags & CDC_NCM_FLAG_NDP_TO_END)
> -		delayed_ndp_size = ALIGN(ctx->max_ndp_size, ctx->tx_ndp_modulus);
> +		delayed_ndp_size = ctx->max_ndp_size +
> +			max((u32)ctx->tx_ndp_modulus,
> +			    (u32)ctx->tx_modulus + ctx->tx_remainder) - 1;

Let's use max_t, like Bjorn suggested.