[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210104234018.GA19909@amd>
Date: Tue, 5 Jan 2021 00:40:18 +0100
From: Pavel Machek <pavel@...x.de>
To: Mark Brown <broonie@...nel.org>
Cc: "Lad, Prabhakar" <prabhakar.csengg@...il.com>,
Geert Uytterhoeven <geert@...ux-m68k.org>,
Pavel Machek <pavel@...x.de>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
Jiri Kosina <trivial@...nel.org>,
Sergei Shtylyov <sergei.shtylyov@...il.com>,
linux-spi <linux-spi@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
Chris Brandt <Chris.Brandt@...esas.com>
Subject: Re: [PATCH 2/2] spi: rpc-if: Remove CONFIG_PM_SLEEP ifdefery
Hi!
> > > > .name = "rpc-if-spi",
> > > > - .pm = DEV_PM_OPS,
> > > > + .pm = &rpcif_spi_pm_ops,
>
> > > You're aware rpcif_spi_pm_ops is now always referenced and thus emitted,
> > > increasing kernel size by 92 bytes if CONFIG_PM_SLEEP=n?
> > > This may matter for RZ/A SoCs running from internal SRAM.
>
> > Hmm didn't realise this would be an issue on RZ/A.
>
> > Mark, could you please drop this patch from your branch.
>
> Please send an incremental patch with an appropriate changelog.
Let's fix this properly. I'm pretty sure we have some macros that can
solve this without re-introducing the ifdefs...
(Besides... 92 bytes. How big is kernel these days? 4MB? More? How
much SRAM do you have?)
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)
Powered by blists - more mailing lists