linux-kernel - Re: [PATCH] x86/compat: Pull huge_encode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f2a28e68-be2c-b83c-feb0-729b1967bc11@infradead.org>
Date:   Mon, 4 Jan 2021 15:55:29 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Josh Poimboeuf <jpoimboe@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH] x86/compat: Pull huge_encode_dev() outside of UACCESS

On 1/4/21 3:14 PM, Josh Poimboeuf wrote:
> On Mon, Jan 04, 2021 at 11:24:23AM -0600, Josh Poimboeuf wrote:
>> On Mon, Jan 04, 2021 at 04:53:47PM +0100, Peter Zijlstra wrote:
>>> On Mon, Jan 04, 2021 at 09:31:27AM -0600, Josh Poimboeuf wrote:
>>>> Peter, care to submit a proper patch?
>>>
>>> Here goes..
>>>
>>> ---
>>> Subject: x86/compat: Pull huge_encode_dev() outside of UACCESS
>>> From: Peter Zijlstra <peterz@...radead.org>
>>> Date: Mon, 4 Jan 2021 13:28:25 +0100
>>>
>>> Fixes the following warning:
>>>
>>>   arch/x86/kernel/sys_ia32.o: warning: objtool: cp_stat64()+0xd8: call to new_encode_dev() with UACCESS enabled
>>>
>>> Reported-by: Randy Dunlap <rdunlap@...radead.org>
>>> Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
>>
>> Acked-by: Josh Poimboeuf <jpoimboe@...hat.com>
> 
> Actually the other patch was already merged into Linus' tree.
> 
> Maybe add a revert of the other patch to this one?
> 

Glad you noticed.

I reverted the kdev_t patch and applied Peter's patch and it
still tested OK, so (still):

Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

-- 
~Randy