linux-kernel - Re: [PATCH v2 -next] misc: ocxl: use DEFINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a27edb92-25e6-0047-96a3-911d06d001fa@linux.ibm.com>
Date:   Mon, 4 Jan 2021 09:50:07 +0100
From:   Frederic Barrat <fbarrat@...ux.ibm.com>
To:     Zheng Yongjun <zhengyongjun3@...wei.com>,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Cc:     ajd@...ux.ibm.com, arnd@...db.de, gregkh@...uxfoundation.org
Subject: Re: [PATCH v2 -next] misc: ocxl: use DEFINE_MUTEX() for mutex lock



On 24/12/2020 14:24, Zheng Yongjun wrote:
> mutex lock can be initialized automatically with DEFINE_MUTEX()
> rather than explicitly calling mutex_init().
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>
> ---


Thanks!
Acked-by: Frederic Barrat <fbarrat@...ux.ibm.com>



>   drivers/misc/ocxl/file.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c
> index 4d1b44de1492..e70525eedaae 100644
> --- a/drivers/misc/ocxl/file.c
> +++ b/drivers/misc/ocxl/file.c
> @@ -15,7 +15,7 @@
>   
>   static dev_t ocxl_dev;
>   static struct class *ocxl_class;
> -static struct mutex minors_idr_lock;
> +static DEFINE_MUTEX(minors_idr_lock);
>   static struct idr minors_idr;
>   
>   static struct ocxl_file_info *find_and_get_file_info(dev_t devno)
> @@ -588,7 +588,6 @@ int ocxl_file_init(void)
>   {
>   	int rc;
>   
> -	mutex_init(&minors_idr_lock);
>   	idr_init(&minors_idr);
>   
>   	rc = alloc_chrdev_region(&ocxl_dev, 0, OCXL_NUM_MINORS, "ocxl");
>