linux-kernel - Re: [PATCH 5/6] block: move three bvec helpers declaration into private helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 4 Jan 2021 09:56:34 +0100
From:   Christoph Hellwig <hch@....de>
To:     Ming Lei <ming.lei@...hat.com>
Cc:     Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org,
        Christoph Hellwig <hch@....de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] block: move three bvec helpers declaration into
 private helper

> +extern struct bio_vec *bvec_alloc(gfp_t, int, unsigned long *, mempool_t *);
> +extern void bvec_free(mempool_t *, struct bio_vec *, unsigned int);
> +extern unsigned int bvec_nr_vecs(unsigned short idx);

Please drop the externs while you're at it.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>