[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20210104083551.1393-1-m.shams@samsung.com>
Date: Mon, 4 Jan 2021 14:05:51 +0530
From: Tamseel Shams <m.shams@...sung.com>
To: kgene@...nel.org, krzk@...nel.org, gregkh@...uxfoundation.org,
jslaby@...e.com
Cc: linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, linux-serial@...r.kernel.org,
linux-kernel@...r.kernel.org, alim.akhtar@...sung.com,
Tamseel Shams <m.shams@...sung.com>
Subject: [PATCH] serial: samsung: Checks the return value of function
"uart_add_one_port" function call may fail and return
some error code, so adding a check for return value.
If it is returning some error code, then displaying the
result and returning back from there.
Signed-off-by: Tamseel Shams <m.shams@...sung.com>
---
drivers/tty/serial/samsung_tty.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
index 6ef614d8648c..a220ba166ffe 100644
--- a/drivers/tty/serial/samsung_tty.c
+++ b/drivers/tty/serial/samsung_tty.c
@@ -2072,7 +2072,11 @@ static int s3c24xx_serial_probe(struct platform_device *pdev)
}
dev_dbg(&pdev->dev, "%s: adding port\n", __func__);
- uart_add_one_port(&s3c24xx_uart_drv, &ourport->port);
+ ret = uart_add_one_port(&s3c24xx_uart_drv, &ourport->port);
+ if (ret < 0) {
+ dev_err(&pdev->dev, "Failed to add uart port, err %d\n", ret);
+ return ret;
+ }
platform_set_drvdata(pdev, &ourport->port);
/*
--
2.17.1
Powered by blists - more mailing lists