linux-kernel - Re: [PATCH] extcon: Add stubs for extcon_register_notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGTfZH20USDdNLLkjC5QsxYnQU6hnG4esbf7gf91pvw0GqZPBQ@mail.gmail.com>
Date:   Mon, 4 Jan 2021 19:32:17 +0900
From:   Chanwoo Choi <cwchoi00@...il.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     MyungJoo Ham <myungjoo.ham@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Hans de Goede <hdegoede@...hat.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Timon Baetz <timon.baetz@...tonmail.com>,
        kbuild-all@...ts.01.org, Lee Jones <lee.jones@...aro.org>,
        Sebastian Reichel <sre@...nel.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] extcon: Add stubs for extcon_register_notifier_all() functions

Hi Krzysztof,

On Thu, Dec 31, 2020 at 5:56 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> Add stubs for extcon_register_notifier_all() function for !CONFIG_EXTCON
> case.  This is useful for compile testing and for drivers which use
> EXTCON but do not require it (therefore do not depend on CONFIG_EXTCON).
>
> Fixes: 815429b39d94 ("extcon: Add new extcon_register_notifier_all() to monitor all external connectors")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>  include/linux/extcon.h | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/include/linux/extcon.h b/include/linux/extcon.h
> index fd183fb9c20f..0c19010da77f 100644
> --- a/include/linux/extcon.h
> +++ b/include/linux/extcon.h
> @@ -271,6 +271,29 @@ static inline  void devm_extcon_unregister_notifier(struct device *dev,
>                                 struct extcon_dev *edev, unsigned int id,
>                                 struct notifier_block *nb) { }
>
> +static inline int extcon_register_notifier_all(struct extcon_dev *edev,
> +                                              struct notifier_block *nb)
> +{
> +       return 0;
> +}
> +
> +static inline int extcon_unregister_notifier_all(struct extcon_dev *edev,
> +                                                struct notifier_block *nb)
> +{
> +       return 0;
> +}
> +
> +static inline int devm_extcon_register_notifier_all(struct device *dev,
> +                                                   struct extcon_dev *edev,
> +                                                   struct notifier_block *nb)
> +{
> +       return 0;
> +}
> +
> +static inline void devm_extcon_unregister_notifier_all(struct device *dev,
> +                                                      struct extcon_dev *edev,
> +                                                      struct notifier_block *nb) { }
> +
>  static inline struct extcon_dev *extcon_get_extcon_dev(const char *extcon_name)
>  {
>         return ERR_PTR(-ENODEV);
> --
> 2.25.1
>

Applied it. Thanks.

-- 
Best Regards,
Chanwoo Choi